Update IE11 deprecation message
What does this MR do?
We have deprecated Internet Explorer 11 in 13.0 already. This removes the extra case for it in the interface and the docs have been updated to just indicate that we dropped it in 13.0.
The link to the feedback issue has been removed and users will still see the outdated browser warning in case they use Internet Explorer
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
- Resolved by Olena Horal-Koretska
See: #214560 (closed)
added Technical Writing documentation frontend labels
changed milestone to %13.4
2 Messages This merge request adds or changes files that require a review from the Technical Writing team. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 40952 "Update IE11 deprecation message"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 40952 "Update IE11 deprecation message"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Documentation review
The following files require a review from a technical writer:
doc/install/requirements.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Dallas Reedy ( @dreedy
) (UTC-7, 9 hours behind@leipert
)Natalia Tepluhina ( @ntepluhina
) (UTC+3, 1 hour ahead of@leipert
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c5220728 and fbb438bb
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.68 MB 2.68 MB - 0.0 %
Note: We do not have exact data for c5220728. So we have used data from: 1e0ff62a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Olena Horal-Koretska
unassigned @andr3
added docsimprovement twfinished labels
@leipert - The changes you made to the
.md
file look good to me, and I've added my responses to the comments in this MR. I'll go ahead and approve this MR. Thanks for looping me in for the review!unassigned @cnorris
- Resolved by Olena Horal-Koretska
@ohoral Could you do the maintainer review please?
enabled an automatic merge when the pipeline for 1b157a88 succeeds
mentioned in commit 74f2dae3
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added typemaintenance label