Feat(FilteredSearchBar): default suggestion config
What does this MR do?
This MR makes the default suggestions configurable for the shared tokens, so the user can specify the suggestion options. This emerges e.g. with filtering issues or merge requests and the default author suggestion cannot be "Any" since that is a valid username. This is a stepping stone to implementing filter controls for the Merge Request analytics page: #229266 (closed)
Screenshots
Before | After* |
---|---|
- Note that this screenshot was taken by using the changes in a newly implemented filter bar. MR to be created.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
Not a lot of risk involved with this MR. It adds a similar ability to the milestone token as with the other tokens and handles specifying an empty list of suggestions, but does not yet use the ability. Tests have been added to cover the new behavior.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #229266 (closed)