Fix Web IDE fork e2e test
What does this MR do?
Creates the fork via API as the fork user (instead of using the api token for the runtime user)
Closes #243677 (closed)
-
Run the test against Staging before merging
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.4
added QA Quality typemaintenance labels
added typefeature label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 40924 "Fix Web IDE fork e2e test"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 40924 "Fix Web IDE fork e2e test"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer QA Nick Westbury ( @nwestbury
) (UTC+1, 9 hours behind@mlapierre
)Dan Davison ( @ddavison
) (UTC-4, 14 hours behind@mlapierre
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerThe
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/184130893 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/184136667 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/184136667 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/184155486 downstream.The
gitlab-qa
downstream pipeline failed! .Unrelated failure: #241546 (closed)
Unrelated failures:
Edited by Mark Lapierre
@ddavison Could you please review this small fix?
assigned to @ddavison and unassigned @mlapierre
mentioned in commit 06a3f976
mentioned in issue gitlab-org/quality/pipeline-triage#44 (closed)
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.removed typefeature label