Skip to content

Introduce CodeCoveragePresenter to PipelineArtifact

Max Orefice requested to merge mo-introduce-code-coverage-presenter into master

Ref: #241141 (closed)

This feature is behind a feature flag (coverage_report_view).

What does this MR do?

This MR introduces a new CodeCoveragePresenter class.

It includes the following items:

  • Adds present public method to our PipelineArtifact
  • Introduces CodeCoveragePresenter to encapsulate specific logic for a code_coverage
  • Uses our new class to present our coverage report to the frontend

Why are we doing this?

As pointed out by @dosuken123 in this thread our business logic should be tightly coupled for providing complete feature set.

By introducing this new class, we are no longer decoupling our business logic to our presentable logic. Which is exactly what a Presentable abtraction does.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports