MR Analytics - Fix throughput chart date range calculation

What does this MR do?

Fixes a bug which caused the MR Analytics Throughput Chart date range calculations to not be accurate.

How to test:

1. Make sure you have starter plan.
2. Enable the feature: Feature.enable(:project_merge_request_analytics)
3. Navigate to the page: some project / analytics / Merge Requests

Before

Sep_2019: mergeRequests(first: 0, mergedBefore: "2019-10-01", mergedAfter: "2019-10-01”)
Oct_2019: mergeRequests(first: 0, mergedBefore: "2019-12-01", mergedAfter: "2019-10-01") 
Nov_2019: mergeRequests(first: 0, mergedBefore: "2019-12-01", mergedAfter: "2019-12-01")
Dec_2019: mergeRequests(first: 0, mergedBefore: "2020-01-01", mergedAfter: "2019-12-01")
Jan_2020: mergeRequests(first: 0, mergedBefore: "2020-03-01", mergedAfter: "2020-01-01") 
Feb_2020: mergeRequests(first: 0, mergedBefore: "2020-03-01", mergedAfter: "2020-03-01") 
Mar_2020: mergeRequests(first: 0, mergedBefore: "2020-05-01", mergedAfter: "2020-03-01")
Apr_2020: mergeRequests(first: 0, mergedBefore: "2020-05-01", mergedAfter: "2020-05-01")
May_2020: mergeRequests(first: 0, mergedBefore: "2020-07-01", mergedAfter: "2020-05-01")
Jun_2020: mergeRequests(first: 0, mergedBefore: "2020-07-01", mergedAfter: "2020-07-01")
Jul_2020: mergeRequests(first: 0, mergedBefore: "2020-08-01", mergedAfter: "2020-07-01") 
Jul_2020: mergeRequests(first: 0, mergedBefore: "2020-08-01", mergedAfter: "2020-07-01")
Aug_2020: mergeRequests(first: 0, mergedBefore: "2020-10-01", mergedAfter: "2020-08-01")

After

Sep_2019: mergeRequests(first: 0, mergedBefore: "2019-10-01", mergedAfter: "2019-09-01”) 
Oct_2019: mergeRequests(first: 0, mergedBefore: "2019-11-01", mergedAfter: "2019-10-01")
Nov_2019: mergeRequests(first: 0, mergedBefore: "2019-12-01", mergedAfter: "2019-11-01")
Dec_2019: mergeRequests(first: 0, mergedBefore: "2020-01-01", mergedAfter: "2019-12-01”) 
Jan_2020: mergeRequests(first: 0, mergedBefore: "2020-02-01", mergedAfter: "2020-01-01") 
Feb_2020: mergeRequests(first: 0, mergedBefore: "2020-03-01", mergedAfter: "2020-02-01”)
Mar_2020: mergeRequests(first: 0, mergedBefore: "2020-04-01", mergedAfter: "2020-03-01")
Apr_2020: mergeRequests(first: 0, mergedBefore: "2020-05-01", mergedAfter: "2020-04-01")
May_2020: mergeRequests(first: 0, mergedBefore: "2020-06-01", mergedAfter: "2020-05-01")
Jun_2020: mergeRequests(first: 0, mergedBefore: "2020-07-01", mergedAfter: "2020-06-01")
Jul_2020: mergeRequests(first: 0, mergedBefore: "2020-08-01", mergedAfter: "2020-07-01")
Aug_2020: mergeRequests(first: 0, mergedBefore: "2020-09-01", mergedAfter: "2020-08-01")

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• [-] Changelog entry
• [-] Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers
• [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

Related issue

#243446 (closed)

changed milestone to %13.4

added devopsmanage frontend groupoptimize priority1 sectiondev typebug workflowin dev labels

changed title from Draft: Resolve "Merge Request Analytics - Fix throughput chart date range calculator" to Draft: MR Analytics - Fix throughput chart date range calculation

changed the description

assigned to @blabuschagne

changed the description

mentioned in issue #243446 (closed)

added 1 commit

• 74c5570b - Fix month range calculation bug

Compare with previous version

1 Message

CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following: bin/changelog -m 40847 "MR Analytics - Fix throughput chart date range calculation" If you want to create a changelog entry for GitLab EE, run the following instead: bin/changelog --ee -m 40847 "MR Analytics - Fix throughput chart date range calculation" If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Alexander Turinske (@aturinske) (UTC-6, 8 hours behind @blabuschagne)	Illya Klymov (@xanf) (UTC+3, 1 hour ahead of @blabuschagne)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

Generated by Danger

added 1 commit

• 7ff178ab - Update util test

Compare with previous version

marked the checklist item Code review guidelines as completed

marked the checklist item Merge request performance guidelines as completed

marked the checklist item Style guides as completed

added feature flag typemaintenance labels and removed workflowin dev label

added typefeature label

unmarked as a Work In Progress

Hey @aturinske could you please perform the initial review on this MR?

assigned to @aturinske

approved this merge request

unassigned @aturinske

@wortschi could you please maintainer review this?

assigned to @wortschi

resolved all threads

approved this merge request

merged

@blabuschagne Thanks for quickly jumping on this - LGTM!

mentioned in commit f2e5eba7

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in merge request gitlab-com/www-gitlab-com!49806 (closed)

This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

added published label

This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

removed typefeature label