Skip to content

Improve readability/extensibility of Design Management specs

Tom Quirk requested to merge fix-design-management-router-tests into master

What does this MR do?

A small change to make createComponent accept an object of props in pages/design/index_spec.js. This is in preparation for a future update to this function will will require us to pass more props.

Also fixes (they weren't "broken", luckily) 2 specs in pages/index_spec.js - the correct data is now being passed to createComponent

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports