Skip to content

Add a warning when some files are collapsed

What does this MR do?

For #232820 (closed)

When any file is collapsed in the MR Changes tab, a dismissable warning is shown at the top.

The warning will only show if no files are hidden (1000+ files in the MR) and there are no merge conflicts, which each show a more pertinent warning.

The outer app remembers if the alert has been interacted with so that after the first dismissal or after all files are expanded the first time, the alert will not show up again until another page refresh.

Screenshots

This gif includes both interactions with the alert.

That is, at the start, it shows how the alert is removed (and the files are expanded) when the user clicks the Expand All button. Immediately after, the view resets (the alert magically pops back into view) and it shows how the alert is dismissed when the user clicks the x in the alert and the alert doesn't return when files are toggled.

after-compressed

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph

Merge request reports