Fix vulnerability comment delete button spinner position

What does this MR do?

When viewing the vulnerability details for a vulnerability on the security dashboard:

If there's a comment on a history item at the bottom, a delete button is shown to delete the comment. Clicking on the button shows two confirmation buttons:

And when the delete button is clicked, a loading spinner is shown on the button, but is positioned incorrectly. This MR fixes that:

Before	After

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• [-] Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• [-] Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

changed milestone to %13.4

added Category:Vulnerability Management UX devopssecure frontend groupthreat insights typefeature workflowin dev labels

	1 Warning
	This merge request changed files with disabled eslint rules. Please consider fixing them.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• ee/app/assets/javascripts/vulnerabilities/components/history_comment.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'ee/app/assets/javascripts/vulnerabilities/components/history_comment.vue'

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Savas Vedova (@svedova) (UTC+3, 13 hours ahead of @dftian)	Jose Ivan Vargas (@jivanvl) (UTC-5, 5 hours ahead of @dftian)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 2c39f672 - Fix vulnerability comment delete button spinner position

Compare with previous version

marked the checklist item Changelog entry as completed

added 1 commit

• 0ff0f068 - Fix vulnerability comment delete button spinner position

Compare with previous version

added 1 commit

• 10dd6703 - Fix vulnerability comment delete button spinner position

Compare with previous version

added 1 commit

• 93b7ce26 - Fix vulnerability comment delete button spinner position

Compare with previous version

@svedova Would you mind reviewing this MR?

assigned to @svedova

changed the description

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits c40d8005 and 93b7ce26

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.53 MB	3.53 MB	-	0.0 %
mainChunk	2.68 MB	2.68 MB	-	0.0 %

---

Note: We do not have exact data for c40d8005. So we have used data from: a7e0fc7f.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

approved this merge request

assigned to @jivanvl and unassigned @svedova

approved this merge request

resolved all threads

Thanks @dftian this looks good to me! Starting a new pipeline and setting MWPS

enabled an automatic merge when the pipeline for a5fb2575 succeeds

merged

mentioned in commit 7c540670

added workflowstaging label and removed workflowin dev label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

added published label

This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

mentioned in issue gitlab-com/www-gitlab-com#8059 (closed)