Skip to content

docs: use pre-built docker image for lsif-go

Mikhail Mazurskiy requested to merge ash2k/use-pre-built-lsif-go into master

What does this MR do?

Recommends to use pre-built docker image instead of building the binary each time.

Reasons:

  • Building master from scratch is not reproducible as repository is being developed. Docker image can be pinned to a tag or digest.
  • go get is a way to add dependencies in Go. So if the project is written in Go dependency conflict might suddenly occur if there are shared dependencies.

Please see the discussion here gitlab-org/cluster-integration/gitlab-agent!68 (comment 401431566)

Related issues

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Marcia Ramos

Merge request reports