Skip to content

Fix board config modal canceling

What does this MR do?

Fixes canceling the board edit modal.

As far as I can tell, canceling the Edit board / Create board / View scope modal is broken because the modal was given a @toggle handler instead of @cancel handler.

I suppose this was caused by a mixup with using the right sidebar. The right sidebar has a @toggle, but modals only have @cancel.

This MR replaces the modal handler with @cancel to enable the X and Cancel buttons.

Are there points in the code the reviewer needs to double check?

Check that the common modal component really doesn't use @toggle.

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ce/issues/42011 https://gitlab.com/gitlab-org/gitlab-ce/issues/42012

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/42011 https://gitlab.com/gitlab-org/gitlab-ce/issues/42012

Edited by Tiberiu Ana

Merge request reports