Skip to content

Update mousetrap from 1.4.6 to 1.6.5

Nathan Friend requested to merge nfriend-upgrade-mousetrap into master

What does this MR do?

Updates mousetrap.js from version 1.4.6 to 1.6.5.

This update includes a small breaking change with how the library expects a custom stopCallback to be defined. All usages of stopCallback in our application have been updated as part of this MR.

Why?

Upgrading allows us to take advantage of a new feature that scopes keyboard shortcuts to a specific element: https://craig.is/killing/mice#wrapping

This feature is being used in !40328 (merged), which implements keyboard shortcuts for markdown editors.

Screenshots

This changes makes no user-facing changes.

Edited by Nathan Friend

Merge request reports