Skip to content

Replace fa-times with GitLab SVG close icon - Forms

What does this MR do?

This is one part of three MR's to replace all occurrences of the fa-times FontAwesome icon with the GitLab UI close icon SVG.

This MR specifically replaces the use of the icon in form related contexts.

Screenshots

Location With FA icon With SVG icon
[HOST]/-/ide/project/[GROUP]/[PROJECT]/edit/[BRANCH]/-/
_Press t --> Search for file_
image image
[HOST]/admin/runners image image
`[HOST]/admin/users/[USERNAME]/projects image image
[HOST]/admin/users/[USERNAME] image image
[HOST]/groups/[GROUP]/-/settings/ci_cd
_Runners_
image image
[HOST]/dashboard/issues?assignee_username=[USERNAME] image image
[HOST]/[GROUP]/[PROJECT]/-/boards
_Add list --> Assignee_
image image
[HOST]/[GROUP]/[PROJECT]/-/issues/[ID]
_Linked issues --> Add_
image image
[HOST]/groups/[GROUP]/-/epics image image
[HOST]/groups/[GROUP]/-/group_members
_Edit button next to member (requires LDAP sync to appear 🙈)_
image image
[HOST]/[GROUP]/[PROJECT]/-/project_members image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

You can either use the paths noted in the screenshots above or review the screenshots themselves. Some of these are very tricky to get to and either require you to have your instance set up a specific way or editing the code to force their display 🙈

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related #224534 (closed)

Edited by Robert Hunt

Merge request reports