Resolve user variable name conflict

What does this MR do?

Resources that have a user attribute no longer override the api client user when that attribute is populated.

This also removes a bunch of assignments - the api user isn't needed when the api client itself is already provided.

Fixes #217002 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading