Skip to content

Update vue-virtual-scroll-list dependency

Juan J. Ramirez requested to merge vue-virtual-scroll-update into master

What does this MR do?

Updates "vue-virtual-scroll-list" to ^2.0.0 to fix a known issue for jumpy tables. We have this issue on the test suite tables. Author says this issue was fixed on v2.0 https://github.com/tangbc/vue-virtual-scroll-list/issues/77

This library is used in our SmartVirtualList component that is used in the following areas:

  1. /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/app/assets/javascripts/pipelines/components/test_reports/test_suite_table.vue (area where we have the jumpy row bug)

  2. /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/app/assets/javascripts/pipelines/components/test_reports/test_summary_table.vue

  3. /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/app/assets/javascripts/reports/components/issues_list.vue

  4. /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/app/assets/javascripts/vue_shared/components/sidebar/labels_select_vue/dropdown_contents_labels_view.vue

  5. /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/ee/app/assets/javascripts/vue_shared/license_compliance/mr_widget_license_report.vue

  6. /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/ee/app/assets/javascripts/vue_shared/metrics_reports/grouped_metrics_reports_app.vue

Screenshots

No breaking behavior verification in areas where this component is used:

3) /Users/jjramirez-gitlab/Desktop/GDK/gdk2/gitlab/app/assets/javascripts/vue_shared/components/sidebar/labels_select_vue/dropdown_contents_labels_view.vue

2020-08-26_12-39-54

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Juan J. Ramirez

Merge request reports