Allow SAST configuration with existing CI file
What does this MR do?
Allow SAST configuration with existing CI file
Previously, the Security Configuration page only linked to the SAST Configuration page for projects without an existing CI file. This was because the initial implementation did not support updating an existing CI file.
Now that the main technical limitation has been lifted (with caveats), the UI can direct users to the SAST Configuration page regardless of whether their project has an existing CI file.
This also changes the configuration button to say "Configure" if the given feature is already configured (by any means), and "Enable" if not. Previously this was based on whether Auto DevOps was enabled, but checking the configured status is more direct.
Addresses #240941 (closed).
Draft
Currently in Draft, as it's based on !40375 (merged) (since there would tricky merge conflicts otherwise).
Screenshots
Description | Before | After |
---|---|---|
Project with no CI file (no change, although the alert is dismissible in After ; this is only because this MR is based on !40375 (merged)) |
![]() |
![]() |
Project with CI file but SAST not configured ( Enable button now visible) |
![]() |
![]() |
Project with CI file and SAST configured ( Configure button now visible) |
![]() |
![]() |
Project with Auto DevOps enabled (no change) |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done