Skip to content

Scope down Chrome version for icon fix

Lukas 'ai-pi' Eipert requested to merge leipert-scope-down-chrome-fix into master

What does this MR do?

Scope down Chrome version for icon fix

When checking the Chromium changelog, we can see that they backported the SVG fix to: 84.0.4147.125 0. So we can actually scope our fix deployment down to that version.

For Edge we have figured out which version to use based on it's useragent: 84.0.522.59, for example:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Safari/537.36 Edg/84.0.522.59

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas 'ai-pi' Eipert

Merge request reports