Skip to content

Merge CE and EE welcome page

Nicolas Dular requested to merge nicolasdular/merge-welcome-frontend into master

What does this MR do?

To not let these two pages diverge (which already happened) we want to merge them and only embedd the parts from EE that are necessery.

For self managed, we also remove the question if the user sets up the account for their company, since this only makes sense for Gitlab.com where it is more likely that someone starts a group and is not already using the GitLab instance soley for their company.

This is the first step to make the welcome page the default, the work for that started here but I wanted to split up the MR: !39339 (closed)

No Changelog because it's still behind the feature flag signup_flow_experiment_percentage.

Part of: gitlab-org/growth/engineering#64 (closed) References: gitlab-org/growth/engineering#5325 (closed)

How to test locally

  1. Enable feature flag: Feature.enable_percentage_of_time(:signup_flow_experiment_percentage, 100)
  2. Go to signup page: http://localhost:3000/users/sign_up
  3. Fill in the signup form
  4. Voila, you're on the welcome page

Screenshots

On self managed On .com
Screenshot_2020-08-26_at_13.05.02 Screenshot_2020-08-26_at_13.05.56

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports