Optimize factory creation in user view issues spec
What does this MR do?
This MR improvises the user view issues spec by reducing the number of database objects created. It's listed in one of the top 10 time consuming specs.
The performance analysis and inference is as listed below:
Before:
[TEST PROF INFO] EventProf results for sql.active_record
Total time: 00:03.759 of 01:00.983 (6.16%)
Total events: 1903
Top 5 slowest suites (by time):
User views issue (./spec/features/issues/user_views_issue_spec.rb:5) – 00:03.759 (1903 / 6) of 01:00.983 (6.16%)Flame Graph:
After:
[TEST PROF INFO] EventProf results for sql.active_record
Total time: 00:02.068 of 00:54.063 (3.83%)
Total events: 1164
Top 5 slowest suites (by time):
User views issue (./spec/features/issues/user_views_issue_spec.rb:5) – 00:02.068 (1164 / 6) of 00:54.063 (3.83%)Flame Graph:
Inferences:
- Number of database queries decreased from 1903 to 1164
- Top-level create stacks reduced from 31 to 11
- Total time was reduced by 37.82%
Queries saved: 793
Mentions gitlab-com/www-gitlab-com#8851 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by John Hope