Skip to content

Geo Statuses - Fix empty section bug

Zack Cuddy requested to merge fix-geo-zero-truthy into master

What does this MR do?

There was a minor bug when we had 0 things to verifiy/checksum that they would be omitted from the section. Of course we don't actually want to omit them but rather show they have queued work.

This change adds some additional checks essentially make 0 a truthy value in this check.

Also added some specs so we avoid this regression in the future 🎉

Screenshots

Verification Section
before (bug) Before
after After

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports