Skip to content

Implement empty state on security dashboard

What does this MR do?

Implement empty state on security dashboard

  • previously there was an empty state that showed on the security dashboards
  • when I migrated the dashboards to use the security charts component, this feature was missed
  • add the empty state back in for the security dashboards
  • update tests

How to reproduce

https://gitlab.com/snippets/1956676

To test the empty state of the group-level security dashboards, create an empty group in your GDK to test the group empty states

To test the instance-level security dashboard, which is still not showing and will be shown in !40303 (closed)), modify the first line in ee/app/assets/javascripts/pages/security/dashboard/show/index.js to be import initFirstClassSecurityDashboard from 'ee/security_dashboard/security_charts_init';

Screenshots

- Before After
Group-level Before_-_group_empty_statel After_-_group_empty_state After_-_with_state
Instance-level Before_-_instance_level After_-_instance_level
Error Message Something went wrong, unable to get projects An error occurred while retrieving projects. + error from backend Screen_Shot_2020-08-28_at_7.57.29_AM

NOTE: The breadcrumbs in the instance-level security dashboard are currently broken, which is being addressed in !40486 (merged)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #230412 (closed)

Edited by Alexander Turinske

Merge request reports