Wrap dashboards dropdown items text
What does this MR do?
This is the implementation MR for #238178 (closed)
Showcase
Before | After | After (video) |
---|---|---|
![]() |
![]() |
Screen_Recording_2020-08-25_at_14.51.30 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.4
added UX devopsmonitor frontend workflowin dev + 1 deleted label
2 Warnings Please add a throughput label to this merge request. You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Fernando Arias ( @farias-gl
) (UTC-5, 6 hours behind@astoicescu
)Enrique Alcántara ( @ealcantara
) (UTC-4, 5 hours behind@astoicescu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Andrei Stoicescu
@nadia_sotnikova Could you please review this? Thanks in advance!
assigned to @nadia_sotnikova
added workflowin review label and removed workflowin dev label
- Resolved by Andrei Stoicescu
@shampton Could you please review this change? Thanks in advance!
assigned to @shampton
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 73200984 and 3dfd8fd5
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.68 MB 2.68 MB - 0.0 %
Note: We do not have exact data for 73200984. So we have used data from: f1e74d6b.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #241145 (closed)
unassigned @shampton
added workflowin dev label and removed workflowin review label
added workflowin review label and removed workflowin dev label
unassigned @nadia_sotnikova
- Resolved by Jose Ivan Vargas
@dbodicherla Could you please review this dashboards dropdown UI change? Thanks in advance!
assigned to @dbodicherla
unassigned @dbodicherla
added sectionops label
- Resolved by Jose Ivan Vargas
@mrincon Could you please review for merging this small change? Thanks in advance!
assigned to @mrincon
@jivanvl Could you please review this for merging? Thanks a lot!
- Resolved by Jose Ivan Vargas
Looks good to me, thanks @astoicescu! Starting a new pipeline and setting MWPS
enabled an automatic merge when the pipeline for 74a982d9 succeeds
mentioned in commit 7d6a27e2
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added grouprespond label and removed 1 deleted label