Skip to content

Paginate profile group notifications

What does this MR do?

This page has a hard to fix N+1 so we need to mitigate it as much as possible.

In this MR we add pagination. We give up on a fast group notification settings lookup in order to load things in alphabetical order, but in exchange we can limit each page to 10 groups, which is a lot faster than loading a couple hundred!

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Refs #28459 (closed)

Edited by Peter Leitzen

Merge request reports