Skip to content

Default Enable Read-Only Legacy Feature Flags

Jason Goodman requested to merge default-enable-legacy-read-only-flags into master

What does this MR do?

Enables :feature_flags_legacy_read_only by default. This makes legacy feature flags read-only on self-managed instances.

Issue: #240985 (closed)

See also: #220228 (closed)

Screenshots

On the index page, legacy flags are read-only:

Screen_Shot_2020-08-24_at_6.14.17_PM

And they are read-only on the edit page. The Save button is disabled.

Screen_Shot_2020-08-24_at_6.15.00_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports