Default Enable Read-Only Legacy Feature Flags
What does this MR do?
Enables :feature_flags_legacy_read_only
by default. This makes legacy feature flags read-only on self-managed instances.
Issue: #240985 (closed)
See also: #220228 (closed)
Screenshots
On the index page, legacy flags are read-only:
And they are read-only on the edit page. The Save button is disabled.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman