Resolve "Expose Alert via Issues Type"
What does this MR do?
This adds the alert_management_alert
to the IssuesType
in the GraphQL API.
This is needed to complete the issues in Epic &3993 (closed), where we show related Alert information on the Incident (Issue with issue_type incident
) page. Having the ability to fetch the alert via the Issue type reduces the number of calls we need to make against the GraphQL API.
To reduce N+1s I have used LookAhead
, and migrated related code to use this.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #240874 (closed)
Edited by Sean Arnold