Skip to content

Allow sign-in via Atlassian Cloud

Drew Blessing requested to merge dblessing-atlassian-integration-sign-in into master

What does this MR do?

Allows users to sign-in via Atlassian cloud.

  • Allows new users and existing users with a linked identity to sign-in via the button on the sign-in page.
  • Allows existing users without a linked identity to link it via the accounts page.

This is accomplished via the new Atlassian Identity model and associated database table added via !40176 (merged), which will allow GitLab users to connect their account to Atlassian Cloud. GitLab will store the OAuth token and refresh token so GitLab can interact with Atlassian JIRA via the API. This will enable further integrations beyond authentication in the future.

This MR is larger than I preferred, but I didn't see a logical place to separate it. Most of the length is due to tests.

Related to #220991 (closed)

Screenshots

Screen_Shot_2020-09-02_at_2.17.58_PM

When Atlassian account not yet connected/linked

Screen_Shot_2020-09-02_at_2.18.58_PM

When Atlassian account connected/linked

Screen_Shot_2020-09-02_at_2.18.49_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports