Skip to content

[RelativePositioning] Never fail to move nulls

Alex Kalderimis requested to merge ajk-relative-positioning-safe-move-nulls into master

What does this MR do?

This addresses #238416 (closed), in specific errors such as https://sentry.gitlab.net/gitlab/gitlabcom/issues/1766076 where NoSpaceLeft is raised when moving nulls.

This is addressed in this MR in two ways:

  • we try harder to make enough space. Up to 10 gaps will be consolidated to make enough space.
  • we stack overflow elements at the edge rather than failing

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports