Adds scripts/trigger-build to ci-review-patterns
What does this MR do?
Add scripts/trigger-build to ci-review-patterns so that review-build-cng failures with changes to scripts/trigger-build are not allow_failure: true due to code-qa-patterns.
In !39987 (merged) scripts/trigger-build was changed and the pipeline had a review-build-cng failure which was allowed to fail. If review-build-cng failed it would have prevented #239336 (closed) which blocked frontend and scheduled master pipelines.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team