Skip to content

Added crossorigin anonymous to preload tags

Tim Zallmann requested to merge tz-update-preload-crossorigin into master

What does this MR do?

This adds the value anonymous to the crossorigin attribute, based on the documentation this should be the right value as we are requesting a static asset from the CDN. I thought that like the other prefetch elements no crossorigin value is needed (https://developer.mozilla.org/en-US/docs/Web/HTML/Preloading_content). It works actually without a value in Firefox but not in Chrome.

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin in chrome apparently no value is not automatically anonymous.

Screenshots

Fixes the following warning that you currently see for the preloading tags.

Bildschirmfoto_2020-08-21_um_15.08.19

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports

Loading