Create instance-level security charts component
What does this MR do?
Create instance-level security charts component
- create separate components just for the instance-level security charts
- modify the init file to use the component
- update CSS of severity component
- add tests
NOTE: This component is only being created in this MR, but not used; the usage will come in the next MR.
How to reproduce
https://gitlab.com/snippets/1956676
Modify the first line of ee/app/assets/javascripts/pages/security/dashboard/show/index.js to be the following
import initFirstClassSecurityDashboard from 'ee/security_dashboard/security_charts_init';Screenshots
I changes the CSS to the first_class_vulnerabilities_severity.vue component. From a global search, there are only three instances of this component (image below), so I have included screen shots for each instance below. The UX of how the widget now looks has already been approved in !37770 (merged)
| Type | Before | After |
|---|---|---|
| Group Security Dashboard Widget Closed |  |
 |
| Group Security Dashboard Widget Open |  |
 |
| Instance Security Dashboard Widget closed |  |
 |
| Instance Security Dashboard Widget open |  |
 |
| What the new component would look like if it were showing - widget closed | - |  |
| What the new component would look like if it were showing - widget open | - |  |
| What the new component would look like if it were showing - widget open | - |  |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #230412 (closed)