Hide projects pending_delete from the project index
What does this MR do?
Overview
In merge request !39367 (merged) I removed the transaction surrounding the project destroy behind a feature flag. In this MR I'm hiding any projects that may be in a half deleted state so that they do not appear on the index and throw a 404.
Technical details
pending_delete is set as soon a project is scheduled for async destruction.
Although an administrator can set projects to delay the deletion for a long period of time that uses a separate flag called marked_for_deletion_at. pending_delete should always mean that the project destruction will begin as soon as it's pulled from the deletion queue.
Related https://gitlab.com/gitlab-org/gitlab/-/issues/24644
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team