Refactor(Analytics): introduce store filter module
What does this MR do?
This MR moves the (now isolated) Value Stream Analytics filter store module to be a shared module used in both Value Stream Analytics and Code Review Analytics.
Both filter bars are behind feature flags, so no Changelog has been created for this change:
- Value Stream:
value_stream_analytics_path_navigation
andvalue_stream_analytics_filter_bar
- Code Review:
code_review_analytics_has_new_search
I apologize for the size of this, but most of these changes made sense to do in the same MR to provide the relevant context. I've tried to separate changes into separate commits to make the review easier.
Screenshots
Value Stream | Code Review |
---|---|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
As these are both behind feature flags the impact is inherently limited. Furthermore, tests have been migrated/merged along with the change and still passes, which should provide some confidence that this still works as expected.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #232465 (closed)