Skip to content

Migrate Bootstrap button to GitLab UI GlButton in Web IDE commit sidebar

Nadia Sotnikova requested to merge 229310-migrate-bootstrap-button into master

What does this MR do?

This MR is meant to migrate two buttons to GlButton, the "Commit" button and the "Discard draft" button.

Light UI
Light_theme_commit___discard_draft_buttons

Making the buttons work in dark theme requires more work.

Dark UI
Screen_Recording_2020-09-10_at_03.12_PM

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #229310 (closed)

Edited by Taurie Davis

Merge request reports