Simplify implementation of AjaxLoadingSpinner
What does this MR do?
Simplify implementation of AjaxLoadingSpinner
The AjaxLoadingSpinner is only used on our branches page. This simplifies the implementation to not show the button again after the delete call is finished, as the row is removed anyhow.
We are also replacing the spinner with a proper GlSpinner and the fontawesome icons with the real sprite_icons.
Furthermore disabled buttons and buttons that actually open a modal for protected branches had the same event listeners attached. This is not necessary, as the event listeners were never called.
The files were moved into the branches sub folder as it is only used on that page.
The test suite has been simplified as well and instead of mocking out jQuery ajax, we just test the event handler directly. This is work which helps us with the jquery-ujs to @rails/ujs migration.
Screenshots
| Before | After |
|---|---|
| before | after-two |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team