Skip to content

Refactor target_id on AuditEvent

Max Woolf requested to merge 220322-refactor-target-id into master

What does this MR do?

  • Adds a target_id column to audit_events
  • Adds target_id to the list of parallel persisted columns in AuditEvent
  • Refactors all known write paths to target_id to use an integer. (😅)
  • Adds missing specs discovered during refactor

Note to @mwoolf: This will need thorough e2e manual testing before initial backend review.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Mentions #220322 (closed)

Edited by Max Woolf

Merge request reports