Skip to content

Commit author for suggestions is note author

James Ramsay (ex-GitLab) requested to merge suggestion-author into master

What does this MR do?

Git differentiates the author and committer so that the person who writes the change can be acknowledged even though someone else committed it. Suggestions may be proposed by a different person to who applies the change. If this information is lost, the provenance of the change can be hard to discern.

Closes #29211 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michelle Gill

Merge request reports