Make highlighting limits stricter
What does this MR do?
Currently, whenever we highlight text via Gitlab::Highlight
as rich text, it takes a long time (~3s). It falls back to plain text highlighting after 3 seoncds due to the limit set via TIMEOUT_FOREGROUND
.
We are reducing that to 1.5 seconds so we don't have to wait that long before falling back to plain highlighting.
We are also reducing MAXIMUM_TEXT_HIGHLIGHT_SIZE
to 512 KB so we don't need to wait 1.5 seconds before falling back as well when highlighting a huge file.
No tests were updated since the constants were being stubbed in tests.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team