Draft: Align flash function calls to use `deprecatedCreateFlash`

What does this MR do?

Replaces calls to createFlash, flash and Flash with deprecatedCreateFlash

This simplifies how we call the createFlash method and will make the next step of updating the function parameters easier.

This is part of &3895 (closed), we are replacing our use of the createFlash function with a new function that takes an object.

Screenshots

No visual changes

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #229101 (closed)