Search UI add issue scope results filtering by state
What does this MR do?
Issue #237932 (closed)
Allow users doing Basic (PostgreSQL backed) or Advanced (Elasticsearch backed) search to filter issue
scope results by the state
field (all, opened, closed). The filtering changes are applied at the Global, Group, and Project search levels.
Updated and added new tests.
To test this manually you will need to have Elasticsearch setup and Advanced Search enabled for at least 1 project.
Videos
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.4
added workflowin dev label
assigned to @terrichu
added 890 commits
-
0d661320...a54aaa00 - 887 commits from branch
master
- dadb2263 - Allow search issues scope to filter by status
- 5c856221 - fixup! Allow search issues scope to filter by status
- 37ee9ef4 - fixup! Allow search issues scope to filter by status
Toggle commit list-
0d661320...a54aaa00 - 887 commits from branch
added database databasereview pending labels
2 Warnings This merge request is quite big (more than 515 lines changed), please consider splitting it into multiple merge requests. This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend André Luís ( @andr3
) (UTC+1, 5 hours ahead of@terrichu
)Mark Florian ( @markrian
) (UTC+1, 5 hours ahead of@terrichu
)database Marius Bobin ( @mbobin
) (UTC+3, 7 hours ahead of@terrichu
)Tiger Watson ( @tigerwnz
) (UTC+10, 14 hours ahead of@terrichu
)backend Sarah Yasonik ( @syasonik
) (UTC-4, same timezone as@terrichu
)Stan Hu ( @stanhu
) (UTC-7, 3 hours behind@terrichu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 21607734 and 971c61e4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.68 MB 2.68 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.search.show 19.71 KB 67.89 KB +48.18 KB 244.5 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@justin_ho
,@leipert
or@mikegreiling
) for review, if you are unsure about the size increase.Note: We do not have exact data for 21607734. So we have used data from: c4b8a022.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- e4ba3a69 - fixup! Allow search issues scope to filter by status
added 1 commit
- af43e036 - fixup! Allow search issues scope to filter by status
added 1 commit
- 039db6f1 - fixup! Allow search issues scope to filter by status
added 1 commit
- 6c168c1f - fixup! Allow search issues scope to filter by status
added 1 commit
- bd9c8fbb - fixup! Allow search issues scope to filter by status
marked the checklist item Changelog entry as completed
added 584 commits
-
bd9c8fbb...81265090 - 573 commits from branch
master
- a798e026 - Allow search issues scope to filter by status
- 0392c442 - fixup! Allow search issues scope to filter by status
- a3b62457 - fixup! Allow search issues scope to filter by status
- 84d2ad11 - fixup! Allow search issues scope to filter by status
- 38ba9409 - fixup! Allow search issues scope to filter by status
- d42fff52 - fixup! Allow search issues scope to filter by status
- 10b78bbb - fixup! Allow search issues scope to filter by status
- 94bb3ce7 - fixup! Allow search issues scope to filter by status
- 2a36568f - fixup! Allow search issues scope to filter by status
- a1350c5c - fixup! Allow search issues scope to filter by status
- 0dbf6c15 - fixup! Allow search issues scope to filter by status
Toggle commit list-
bd9c8fbb...81265090 - 573 commits from branch
added 1 commit
- 1e4da516 - fixup! Allow search issues scope to filter by status
marked the checklist item Style guides as completed
marked the checklist item Separation of EE specific content as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
added 1 commit
- 3d987bb0 - fixup! Allow search issues scope to filter by status
added 1 commit
- 3d8df5fc - fixup! Allow search issues scope to filter by status
- Resolved by Terri Chu
added 1 commit
- a94e1628 - fixup! Allow search issues scope to filter by status
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
assigned to @mbobin
added 218 commits
-
a94e1628...4e12f87c - 203 commits from branch
master
- d0912316 - Allow search issues scope to filter by status
- d033de08 - fixup! Allow search issues scope to filter by status
- 5b5299d1 - fixup! Allow search issues scope to filter by status
- 9b892281 - fixup! Allow search issues scope to filter by status
- b533563d - fixup! Allow search issues scope to filter by status
- e8263070 - fixup! Allow search issues scope to filter by status
- 10c53fac - fixup! Allow search issues scope to filter by status
- 4211dc56 - fixup! Allow search issues scope to filter by status
- 884e62c4 - fixup! Allow search issues scope to filter by status
- b1e474a7 - fixup! Allow search issues scope to filter by status
- 2e3fcca7 - fixup! Allow search issues scope to filter by status
- 7ef78b2d - fixup! Allow search issues scope to filter by status
- 4e43aa49 - fixup! Allow search issues scope to filter by status
- c003632f - fixup! Allow search issues scope to filter by status
- 9fe65d7a - fixup! Allow search issues scope to filter by status
Toggle commit list-
a94e1628...4e12f87c - 203 commits from branch
- Resolved by Tiger Watson
@mbobin are you available for an initial database review? See my note above regarding the only change related to database.
added workflowin review label and removed workflowin dev label
assigned to @zcuddy
assigned to @dgruzd
- Resolved by Dmitry Gruzd
@dgruzd are you available for the initial backend review?
- Resolved by Terri Chu
assigned to @ebanks
@ebanks would you mind looking over the testing in this MR? Is there anything you would recommend?
added 1 commit
- 6b372891 - fixup! Allow search issues scope to filter by status
marked as a Work In Progress from 6b372891
unassigned @mbobin
- Resolved by Terri Chu
- Resolved by Terri Chu
unassigned @dgruzd
added 1 commit
- 7d630f51 - fixup! Allow search issues scope to filter by status