Skip to content

Make metrics dashboard embeds work with new and old URLs

What does this MR do?

We added a new dashboard route in #226002. The goal was to have a dashboard route that does not contain an environment ID, so that we can move towards a metrics dashboard that does not require an environment to exist.

Dashboard embeds should work with these new routes as well as the old. This MR updates the regex used by the GFM to recognize metrics dashboard URLs so that it matches the new URL as well.

Old URL: https://<host>/<namespace>/<project>/-/environments/<env_id>/metrics

New URL: https://<host>/<namespace>/<project>/-/metrics?environment=<env_id>

Issue: #227929 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Reuben Pereira

Merge request reports