Skip to content

Use with let_it_be in features/boards_spec

Eugenia Grieff requested to merge feature-boards-spec-improvment into master

What does this MR do?

Replace let with the helper let_it_be in spec/features/boards/boards_spec.rb to reduce the number of DB queries.

Queries saved: 14080

  • Saved time: 16 seconds (44.44%)

Before

[TEST PROF INFO] EventProf results for sql.active_record

Total time: 00:36.242 of 04:36.400 (13.11%)
Total events: 30008

After

[TEST PROF INFO] EventProf results for sql.active_record

Total time: 00:19.762 of 03:44.260 (8.81%)
Total events: 15928

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Eugenia Grieff

Merge request reports