Skip to content

Use correct order when repositioning existing designs

Markus Koller requested to merge fix-move-null-designs into master

What does this MR do?

Unpositioned designs are sorted by ID, so we need to explictly specify that order when calling move_nulls_to_end.

We also always need to reload the design objects in case their position was changed in the DB by the move_nulls_to_end call.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports