Skip to content

Remove deprecated IE11 Esc key case

What does this MR do?

Apparently KeyboardEvent.key is Esc in IE11 while other browsers use Escape. After a quick check in BrowserStack, Edge 17 and 18 also use Escape, so we can get rid of the Esc case.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports

Loading