Remove project selector logic from dashboard
What does this MR do?
Related to #230413 (closed)
- Removes the Edit Dashboard / Return to dashboard button from the instance level security dashboard.
- Links the empty state to the settings page instead of toggling the project manager.
The Why
We're redesigning the Security Dashboards. Previously we had a single Security Dashboard page which contained the list of vulnerabilities, vulnerability statistics (charts) and the settings page under one view. Now we're iterating towards a version where we have a left navigation bar and three links (Security Dashboard, Settings and Vulnerabilities). The new Security Dashboard will contain only the charts. In a previous MR I have created the Settings page, which is essentially the same component that was shown when Edit Dashboard button was clicked, but in a standalone page. Since now we have the Settings endpoint enabled, the Edit Dashboard becomes redundant. That's why we're removing it.
The linked issue has little information in it because the parent epic contains the whole picture. This design issue perhaps can help better to understand the why.
Screenshots
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team