Skip to content

Refactor(VSA): Separate query and state management

What does this MR do?

This MR refactors the cycle analytics filter bar to handle its own state and query parameters, separating the store module to be used by other analytics filter bars. This is a stepping stone towards implementing a general filter bar solution for analytics.

In the process changes the url-sync component to merge URL parameters, so it works as expected with nested components using it. Note: So far only this page is using the url-sync component!

This filter bar is behind a feature flag and there is, therefore, no changelog entry in this MR.

Screenshots

There is no change to the behavior, this just changes state management

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This does impose some risk as it moves state management around. However, using getters the needed state is still made available where it is needed elsewhere. Furthermore, these parts of the application are covered with tests, which is reflected in the needed changes to these.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #232465 (closed)

Edited by Martin Wortschack

Merge request reports