Skip to content

Improve running git gc during repository cleanup

Nick Thomas requested to merge 220104-git-gc-should-prune-objects into master

What does this MR do?

Without these changes, housekeeping may not make some objects unavailable immediately, and disk space used by the repository may go up instead of down.

We've marked the repository as read-only for the duration of the operation, so it is safe to do a git gc --prune=24.hours.ago (added as the :prune action)

Once this is in, we may want to return to using git gc --prune=now for maximum effect, but that's a Gitaly-side change. Being read-only, again, makes this safe enough.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #220104 (closed)

Edited by Nick Thomas

Merge request reports