Skip to content

Allow dynamic files for Conan package uploads

Steve Abrams requested to merge 210550-conan-missing-files into master

What does this MR do?

When publishing Conan packages to the GitLab package registry, the Conan client will make a request to fetch the upload urls for each file to be uploaded. Currently, we return a static list of files based on a list of pre-set files. https://gitlab.com/gitlab-org/gitlab/blob/master/lib/gitlab/regex.rb#L6-7

This MR updates to follow the behavior that is actually expected by Conan. The Conan client provides a list of files that need to be uploaded in the request body along with their respective filesizes. Here, we update the API code to return the list of upload urls based on the list of files requested instead of using the static list. This fixes a problem where users were unable to upload optional, but common package files such as conan_sources.tgz and conan_export.tgz.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related #210550 (closed)

Edited by Steve Abrams

Merge request reports