Skip to content

[RUN-AS-IF-FOSS] Fix order of imports in JavaScript files

Vitaly Slobodin requested to merge vs-fix-import-orders-in-js into master

What does this MR do?

Fix order of imports in JavaScript files as a preparation step for gitlab-org/frontend/eslint-plugin#6 (closed)

We follow this imports order:

// 1. "external" modules
import _ from 'lodash';
import chalk from 'chalk';
// 2. "internal" and aliased modules
// (if you have configured your path or webpack to handle your internal paths differently)
import foo from 'src/foo';
// 3. modules from a "parent" directory
import foo from '../foo';
import qux from '../../foo/qux';
// 4. "sibling" modules from the same or a sibling's directory
import bar from './bar';
import baz from './bar/baz';
import main from './';

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jose Ivan Vargas

Merge request reports