Skip to content

Set default type for alert embeds

Sarah Yasonik requested to merge sy-set-default-type-for-alert-embeds into master

What does this MR do?

Sets a type for metrics embeds based on gitlab-managed prometheus alerts.

This will enable the FE to render a link to the logs corresponding to the alert.

Related issue/relevant comment: #217769 (comment 394183006)

Screenshots

Visable dropdown Clicking the View logs button
Screen_Shot_2020-08-13_at_1.50.55_PM Screen_Shot_2020-08-13_at_1.51.07_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports