Ajk globalid ignore EE
What does this MR do?
In 7000489d a top-level query for Iterations was introduced, but this accidentally used the type EE::Iteration
(due to namespace nesting). This however leads to the ID for this argument being reported as EEIterationID
with is a) ugly and b) incorrect since iterations are in Core and c) will make it impossible to move this field to Core since that would be backwards incompatible.
This MR fixes this by:
- correctly using the absolute type name in the parameterized global ID type.
- adding a backwards compatibility layer to the schema so it treats client provided types named
EE{type}ID
as if they are{type}ID
. This is also ugly, but we cannot break clients.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis