Skip to content

Fix bugs around Filtered Search Bar

Kushal Pandya requested to merge kp-fix-duplicate-token-keys into master

What does this MR do?

This MR fixes two bugs around app/assets/javascripts/vue_shared/components/filtered_search_bar/ component;

  • History dropdown not hiding even when recentSearchesStorageKey prop is not provided.
  • Token's key prop value is duplicated when same token is selected twice.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#212543 (closed) #213975 (closed)

Merge request reports